CHORE: Couple mssql-python to mssql-python-odbc==18.6.2#687
Merged
Conversation
Add exact-pinned mssql-python-odbc==18.6.2 to install_requires so mssql-python pulls the standalone ODBC Driver 18 package. Loader remains fallback-safe (uses bundled libs when the external package is absent/incomplete). AB#46586
Contributor
There was a problem hiding this comment.
Pull request overview
This PR couples mssql-python to the standalone ODBC driver binary distribution by adding a pinned mssql-python-odbc==18.6.2 dependency to setup.py, so the driver binaries can be resolved via a separate wheel as part of the ODBC package-split release.
Changes:
- Add
mssql-python-odbc==18.6.2toinstall_requiresinsetup.py.
bewithgaurav
previously approved these changes
Jul 22, 2026
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 59.9%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 76.1%
mssql_python.pybind.connection.connection.cpp: 76.2%
mssql_python.__init__.py: 77.3%
mssql_python.row.py: 77.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.connection.py: 83.6%
mssql_python.logging.py: 85.5%🔗 Quick Links
|
bewithgaurav
approved these changes
Jul 23, 2026
subrata-ms
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request updates the packaging configuration in
setup.pyto improve dependency management and avoid conflicts between distributions. The main changes ensure that themssql_python_odbcpackage is no longer included directly in this distribution, but is instead required as an explicit dependency.Dependency management improvements:
find_packagescall to exclude themssql_python_odbcpackage and its submodules, preventing duplicate ownership of the same import directory and potential uninstall issues.mssql-python-odbc==18.6.2toinstall_requires, ensuring the required ODBC driver binaries are installed as a dependency rather than bundled directly.